[bcs]Add Serialized type and serialization methods for handling byte arrays #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tespace in main.go and script.go
gregnazario
reviewed
Mar 11, 2025
Comment on lines
+1
to
+29
| package bcs | ||
|
|
||
| // Serialized represents a serialized transaction argument | ||
| type Serialized struct { | ||
| Value []byte | ||
| } | ||
|
|
||
| // NewSerialized creates a new Serialized instance | ||
| func NewSerialized(value []byte) *Serialized { | ||
| return &Serialized{ | ||
| Value: value, | ||
| } | ||
| } | ||
|
|
||
| // Serialize serializes the Serialized instance | ||
| func (s *Serialized) Serialized(serializer *Serializer) { | ||
| serializer.WriteBytes(s.Value) | ||
| } | ||
|
|
||
| // SerializeForEntryFunction serializes the Serialized instance for entry function | ||
| func (s *Serialized) SerializedForEntryFunction(serializer *Serializer) { | ||
| s.Serialized(serializer) | ||
| } | ||
|
|
||
| // SerializeForScriptFunction serializes the Serialized instance for script function | ||
| func (s *Serialized) SerializedForScriptFunction(serializer *Serializer) { | ||
| serializer.Uleb128(uint32(9)) | ||
| s.Serialized(serializer) | ||
| } |
There was a problem hiding this comment.
In what situation would this not work as a vector? It should be encoded as bytes right?
or is there something I'm missing
gregnazario
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support new Serialized type for Script.
Test Plan
examples/script_transactionRelated Links
ts-sdk: aptos-labs/aptos-ts-sdk@5387884